turn terminal scrop selector into a dropdown #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert Worktree/Global button tabs to Select dropdown component - Add visual icons (TreePine for Worktree, Globe for Global) - Improve space utilization and modernize terminal interface - Maintain all existing functionality and disabled states - Adjust dropdown width to accommodate icons and full text 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add proper screen reader-only descriptions for ARIA attributes: - terminal-scope-description: explains the selector's purpose - workspace-disabled-reason: explains when workspace option is disabled - global-disabled-reason: explains when global option is disabled This resolves accessibility violations where aria-describedby referenced non-existent elements. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Convert double quotes to single quotes for consistency - Apply standard Prettier formatting rules - Now passes npm run format:check 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
@notkainoa is attempting to deploy a commit to the General Action Team on Vercel. A member of the Team first needs to authorize it. |
Resolves merge conflicts in WorkspaceTerminalPanel.tsx by keeping the dropdown selector implementation (feature of this PR) and removing conflicting tab-based tooltip enhancements from main branch. - Preserves dropdown UI with TreePine/Globe icons - Maintains accessibility improvements and optimized telemetry imports - Removes unused Tooltip component imports - Type-check and lint validation passed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add comprehensive ARIA attributes for screen reader support - Implement loading states during terminal switching - Add automatic focus management for better UX - Optimize theme calculation performance - Improve error handling and user feedback - Simplify terminal creation code 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
thanks for contributing! i'd prefer the options to be rendered without the icons because i think the tree icon is not super intuitive. otherwise looks great |
Remove TreePine and Globe icons from terminal scope selector dropdown, keeping only text labels for cleaner appearance. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Author
|
Done. Removed the icons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Terminal scrope tab selector to be a dropdown.
Improvements